[tor-bugs] #4773 [Tor]: Implement Extended OR port (part of proposal 180)

[Tor Bug Tracker & Wiki]

#4773: Implement Extended OR port (part of proposal 180)
------------------------------------------+---------------------------------
 Reporter:  asn                           |          Owner:                    
     Type:  defect                        |         Status:  needs_revision    
 Priority:  normal                        |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                           |        Version:                    
 Keywords:  pt needs-proposal tor-bridge  |         Parent:  #5408             
   Points:                                |   Actualpoints:                    
------------------------------------------+---------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Here are my notes; I'm happy to make these changes myself before merging.
 I plan to do them myself once #8949 is merged, unless somebody else does
 first. I'm just copying them here so I don't lose them.

  * Where are the tests??  There are literally no new tests for all this
 code.  I'll write some after #8949.
  *

  * "char cookie_file_str_len" -- what if the length is over 127?  size_t
 would seem more sensible.
  * Wipe cookie_file_str before freeing it.

  * Do EXT_OR connections interoperate with channels correctly? I should
 investigate

  * connection_ext_or_auth_handle_client_nonce needs comments.
  * connection_ext_or_auth_handle_client_nonce should wipe.
  * connection_ext_or_auth_handle_client_hash should wipe
  * connection_ext_or_auth_process_inbuf state machine should be documented
  * wipe provided_client_hash.

  * In connection_ext_or_handle_useraddr -- Use tor_memdup_nulterm(), AND
 check for internal NULs.

  * The <= AUTH_MAX test seems obscure.  We should add a function to
 describe what that set of states mean.

  * We should wipe ext_or_auth_cookie before freeing it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4773#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online