[tor-bugs] #8929 [Tor]: Pass server-side pluggable transport parameters to proxies

[Tor Bug Tracker & Wiki]

#8929: Pass server-side pluggable transport parameters to proxies
---------------------------+------------------------------------------------
 Reporter:  asn            |          Owner:                    
     Type:  task           |         Status:  needs_revision    
 Priority:  normal         |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor            |        Version:                    
 Keywords:  tor-bridge pt  |         Parent:                    
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Here are my notes; I'm happy to make these changes myself before merging.
 I plan to do them myself once #8949 is merged.  I'm just copying them here
 so I don't lose them.

   * In tor_escape_str_for_pt_args: document what "escape" means.
   * In get_options_from_transport_options_line():
     * add_strdup, not add_asprintf("%s")
     * escape option before logging.
     * Use option_sl_idx, not i.
   * get_transport_options_for_server_proxy: Document that it can return
 NULL.
   * fix memory leaks in tests
   * Make sure all new functions have tests.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8929#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online