[tor-bugs] #7656 [TorBrowserButton]: Stop automated redundant tor browser requests; disable network.http.connection-retry-timeout

[Tor Bug Tracker & Wiki]

#7656: Stop automated redundant tor browser requests; disable network.http
.connection-retry-timeout
---------------------------------+------------------------------------------
    Reporter:  cypherpunks       |       Owner:  mikeperry
        Type:  defect            |      Status:  reopened 
    Priority:  blocker           |   Milestone:           
   Component:  TorBrowserButton  |     Version:           
  Resolution:                    |    Keywords:           
      Parent:                    |      Points:           
Actualpoints:                    |  
---------------------------------+------------------------------------------

Comment(by arma):

 I hacked my Tor client to track things better:
 {{{
 @@ -1256,7 +1257,7 @@ connection_handle_listener_read(connection_t *conn,
 int new_type)
      connection_mark_for_close(conn);
      return -1;
    }
 -  log_debug(LD_NET,
 +  log_notice(LD_NET,
              "Connection accepted on socket %d (child of fd %d).",
              (int)news,(int)conn->s);
  diff --git a/src/or/relay.c b/src/or/relay.c
 index a942e44..26a2699 100644
 --- a/src/or/relay.c
 +++ b/src/or/relay.c
 @@ -1619,6 +1619,13 @@ connection_edge_package_raw_inbuf(edge_connection_t
 *conn, int package_partial,
              conn->base_.s,
              (int)length, (int)connection_get_inbuf_len(TO_CONN(conn)));

 +  if (conn->base_.type == CONN_TYPE_AP) {
 +    char *text = tor_memdup(payload, length+1);
 +    text[length] = 0;
 +    log_notice(LD_APP, "Incoming socks text:===\n%s\n===", text);
 +    tor_free(text);
 +  }
 +
    if (sending_optimistically && !sending_from_optimistic) {
      /* This is new optimistic data; remember it in case we need to detach
 and
         retry */
 }}}

 And a fetch in my tor browser for http://freehaven.net/~arma/cv.html
 results in
 {{{
 Jan 14 02:05:05.000 [notice] Connection accepted on socket 14 (child of fd
 6).
 Jan 14 02:05:05.000 [notice] Connection accepted on socket 15 (child of fd
 6).
 Jan 14 02:05:06.000 [notice] Incoming socks text:===
 GET /~arma/cv.html HTTP/1.1
 Host: freehaven.net
 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:10.0) Gecko/20100101
 Firefox/10.0
 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
 Accept-Language: en-us,en;q=0.5
 Accept-Encoding: gzip, deflate
 Connection: keep-alive


 ===
 }}}

 So it would seem that I am getting two socks connections (as expected),
 but only one of them generates an http request onto the circuit.

 So perhaps this issue isn't so bad after all.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7656#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online