[tor-bugs] #7866 [Stem]: Stem doesn't handle "dir-source *-legacy" lines correctly

[Tor Bug Tracker & Wiki]

#7866: Stem doesn't handle "dir-source *-legacy" lines correctly
---------------------+------------------------------------------------------
 Reporter:  karsten  |          Owner:  atagar
     Type:  defect   |         Status:  new   
 Priority:  normal   |      Milestone:        
Component:  Stem     |        Version:        
 Keywords:           |         Parent:        
   Points:           |   Actualpoints:        
---------------------+------------------------------------------------------

Comment(by karsten):

 Oh, I see.  I agree that dir-spec may need an update.  The "dir-source
 *-legacy" line should be considered a special kind of authority section,
 because these lines are not part of the non-legacy groups of the
 respective authorities.  And then the "exactly once" parts don't apply
 anymore.  I guess 3.3 needs to be changed for this, whereas 3.5 can
 (mostly) stay the same.  Here's a quick suggestion, feel free to polish.

 {{{
 diff --git a/dir-spec.txt b/dir-spec.txt
 index ca5434b..875501e 100644
 --- a/dir-spec.txt
 +++ b/dir-spec.txt
 @@ -1340,28 +1340,34 @@

     The authority section of a consensus contains groups the following
 items,
     in the order given, with one group for each authority that contributed
 to
 -   the consensus, with groups sorted by authority identity digest:
 +   the consensus and for each vote with legacy-key entry, with groups
 sorted
 +   by authority identity digest:

      "dir-source" SP nickname SP identity SP address SP IP SP dirport SP
         orport NL

          [Exactly once, at start]

 -        As in the authority section of a vote.
 +        As in the authority section of a vote, or using the legacy-key's
 +        fingerprint, the voter's ordinary nickname with the string
 +        "-legacy" appended, and all other fields as from the original
 +        vote's dir-source line.

      "contact" SP string NL

 -        [Exactly once.]
 +        [At most once.]

 -        As in the authority section of a vote.
 +        As in the authority section of a vote.  Only present if this
 group
 +        does not represent a legacy key.

      "vote-digest" SP digest NL

 -        [Exactly once.]
 +        [At most once.]

          A digest of the vote from the authority that contributed to this
          consensus, as signed (that is, not including the signature).
 -        (Hex, upper-case.)
 +        (Hex, upper-case.)  Only present if this group does not represent
 +        a legacy key.

     Each router status entry contains the following items.  Router status
     entries are sorted in ascending order by identity digest.
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7866#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online