[tor-bugs] #8302 [Tor bundles/installation]: Various aspects of Tor Browser branding broken for some builds

[Tor Bug Tracker & Wiki]

#8302: Various aspects of Tor Browser branding broken for some builds
--------------------------------------------------+-------------------------
 Reporter:  mikeperry                             |          Owner:  erinn
     Type:  defect                                |         Status:  new  
 Priority:  critical                              |      Milestone:       
Component:  Tor bundles/installation              |        Version:       
 Keywords:  tbb-rebase-regression, tbb-usability  |         Parent:       
   Points:                                        |   Actualpoints:       
--------------------------------------------------+-------------------------

Comment(by erinn):

 It looks like more of the branding is handled within the langpack XPIs
 now. I was able to "fix" this on my local bundles by merely editing and
 re-zipping one, but I'm working on figuring out the best way to do that
 per-bundle. Some of our own changes either get inherited or reset stuff
 that is inside the langpacks (e.g., our browserconfig.properties is
 correct), but looking at the way some of the other files are structured
 and localized (brand.dtd, brand.properties, the two main files that need
 fixin').

 We don't currently create a brand.dtd or brand.properties on a per-
 language basis except for en-US. Those files are correct which is why the
 en-US bundle is not broken. Assuming post-process shell script madness on
 XPIs is too icky and prone to breakage, a possible solution would be to
 try either creating a canonical brand.dtd and brand.properties that is
 inherited by all languages (as browserconfig.properties is) or creating
 per-language branding directories. I'm not sure if either will work; the
 former because I don't know if Firefox can/will inherit like that, the
 latter because I'm not sure the language stuff gets built in without
 building a targetted language Firefox.

 More investigation required. Will report back if I find anything new or
 interesting.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8302#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online