[tor-bugs] #8329 [Ooni]: ooni: txscapy: PcapDummyWriter has different signature method than PcapWriter

[Tor Bug Tracker & Wiki]

#8329: ooni: txscapy: PcapDummyWriter has different signature method than
PcapWriter
-----------------------------+----------------------------------------------
 Reporter:  isis             |          Owner:  isis        
     Type:  defect           |         Status:  needs_review
 Priority:  normal           |      Milestone:              
Component:  Ooni             |        Version:              
 Keywords:  ooni, bugreport  |         Parent:              
   Points:                   |   Actualpoints:              
-----------------------------+----------------------------------------------
Changes (by isis):

  * status:  new => needs_review


Comment:

 if DummyPcapWriter is modified to:

 {{{
     class DummyPcapWriter:
         def __init__(self, pcap_filename, *arg, **kw):
             log.err("Initializing DummyPcapWriter. We will not actually
 write to a pcapfile")

         @staticmethod
         def write(self):
             pass
 }}}

 with the '@staticmethod' added, this error no longer occurs. This is
 included in my branch feature/tls-handshake-rebase, commit
 0164db4fb9c55856e436f9f6101917d6890834c3 .

 I'm opening a new bug for the second traceback, since that is a separate
 issue.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8329#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online