[tor-bugs] #8231 [Tor]: Clients can go crazy when unable to find directory guards

[Tor Bug Tracker & Wiki]

#8231: Clients can go crazy when unable to find directory guards
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  critical    |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor         |        Version:                    
 Keywords:  tor-client  |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 {{{
 +  if (entry_guard_get_by_id_digest(node->identity) != NULL) {
 +    log_info(LD_CIRC, "I was about to add a duplicate entry guard.");
 +    /* This can happen if we choose a guard, then the node goes away,
 then
 +     * comes back. */
 +    ((node_t*) node)->using_as_guard = 1;
 +    return NULL;
 +  }
 }}}

 don't we want to return the guard here, to show success?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8231#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online