[tor-bugs] #3944 [Tor bundles/installation]: TBB prefs are set as user_prefs (may cause exceptions/settings errors?)

[Tor Bug Tracker & Wiki]

#3944: TBB prefs are set as user_prefs (may cause exceptions/settings errors?)
---------------------------------------+------------------------------------
 Reporter:  mikeperry                  |          Owner:  erinn                        
     Type:  defect                     |         Status:  new                          
 Priority:  major                      |      Milestone:  TorBrowserBundle 2.3.x-stable
Component:  Tor bundles/installation   |        Version:                               
 Keywords:  tbb-bounty, tbb-usability  |         Parent:                               
   Points:                             |   Actualpoints:                               
---------------------------------------+------------------------------------

Comment(by mikeperry):

 I have a few questions/comments:

 1. Shouldn't we place the Torbutton preferences in extension-overrides.js
 too? Is there a reason why we didn't? We can probably actually just
 eliminate most of these entirely, though. I can work on that bit in
 Torbutton.

 2. If users change their addon preferences (NoScript for example), will
 those values take precedence over extension-overrides.js? Ie will prefs.js
 extension prefs override extension-overrides.js? I think we want this to
 be the case.

 3. Can we entirely remove the prefs.js from the distribution? A key goal
 here is not overwriting user preferences during updates.

 4. There may be some more prefHasUserValue checks in Torbutton. I'll get
 to those soon.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3944#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online