[tor-bugs] #7902 [Tor]: connection_ap_process_end_not_open() does not handle END_STREAM_REASON_DONE correctly
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Feb 7 20:46:08 UTC 2013
#7902: connection_ap_process_end_not_open() does not handle END_STREAM_REASON_DONE
correctly
-----------------------+----------------------------------------------------
Reporter: asn | Owner:
Type: defect | Status: closed
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version:
Resolution: fixed | Keywords: tor-client
Parent: | Points:
Actualpoints: |
-----------------------+----------------------------------------------------
Comment(by mikeperry):
Hrmm. I have two questions here:
1. Do we really want to retry these streams on new circuits? Changing the
reason code to MISC in connection_ap_process_end_not_open() seems to cause
us to do so.
2. I think this means I should add an endreason == END_STREAM_REASON_DONE
to the path bias check at the beginning of
connection_ap_handshake_socks_reply(). I think we want to count such
connection refused cases as valid use, as the client is *not* going to
retry them on a new circuit at that point.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7902#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list