[tor-bugs] #10398 [TorBrowserButton]: Please do not create strings untranslatable with Transifex

[Tor Bug Tracker & Wiki]

#10398: Please do not create strings untranslatable with Transifex
----------------------------------+-----------------------
     Reporter:  lunar             |      Owner:  mikeperry
         Type:  defect            |     Status:  new
     Priority:  normal            |  Milestone:
    Component:  TorBrowserButton  |    Version:
   Resolution:                    |   Keywords:
Actual Points:                    |  Parent ID:
       Points:                    |
----------------------------------+-----------------------

Comment (by mcs):

 We did not realize/think about the fact that Transifex would make it
 impossible to see the spaces.  We followed the kind of scheme Mozilla uses
 for similar text within the Firefox about box, e.g.,

 http://mxr.mozilla.org/mozilla-esr24/source/browser/locales/en-
 US/chrome/browser/aboutDialog.dtd#20

 (they also use trailing spaces).

 The easiest fix is to move the spaces into aboutTor.xhtml and remove them
 from the localization process.  It is possible for some locale that a
 space between the pieces would not be desirable, but I don't know of a
 real world example.  The advantage of this solution is that we can
 probably keep all of the existing translated strings.

 Another approach would be to use more of the sprintf approach as lunar
 suggested.  We could have a property string something like this:

 aboutTor.searchSP.privacy=Search <a href="%1$S">securely</a> with <a
 href="%2$S">Start Page</a>.

 The strings for %1$S and %2$S would come from localizable properties as
 well, e.g.,

 aboutTor.searchSP.privacy.link=https://startpage.com/eng/protect-
 privacy.html
 aboutTor.searchSP.search.link=https://startpage.com/

 This would still give translators control over the order of items within
 the final string, etc. with the downside that the existing entities would
 need to be thrown out.  Also, translators would have to preserve the HTML
 tags and balance quoting within the one string, which is very fragile.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10398#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online