[tor-bugs] #9531 [TorBrowserButton]: More Torbutton hangs on New Identity control port access

[Tor Bug Tracker & Wiki]

#9531: More Torbutton hangs on New Identity control port access
------------------------------+---------------------------------------------
 Reporter:  mikeperry         |          Owner:  mikeperry
     Type:  defect            |         Status:  new      
 Priority:  major             |      Milestone:           
Component:  TorBrowserButton  |        Version:           
 Keywords:  tbb-usability     |         Parent:           
   Points:                    |   Actualpoints:           
------------------------------+---------------------------------------------

Comment(by cypherpunks):

 Socket is never alive during repro case that leads to hangs. Tested with
 modified torbutton_send_ctrl_cmd() so it waited alive socket after opening
 stream, like so:
 {{{
     var input = socket.openInputStream(3, 1, 1); // 3 ==
 OPEN_BLOCKING|OPEN_UNBUFFERED
     var output = socket.openOutputStream(3, 1, 1); // 3 ==
 OPEN_BLOCKING|OPEN_UNBUFFERED

     while (!socket.isAlive()) {}
     torbutton_log(4, "Alive!");
 }}}
 If hangs happens then it never reaches "Alive!" and browser ask about
 unresponsive script later.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9531#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online