[tor-bugs] #9507 [HTTPS Everywhere: Chrome]: Releasing HTTPS Everywhere 2013.8.16 from the master branch seems to break Chrome

[Tor Bug Tracker & Wiki]

#9507: Releasing HTTPS Everywhere 2013.8.16 from the master branch seems to break
Chrome
--------------------------------------+-------------------------------------
 Reporter:  pde                       |          Owner:  pde
     Type:  defect                    |         Status:  new
 Priority:  blocker                   |      Milestone:     
Component:  HTTPS Everywhere: Chrome  |        Version:     
 Keywords:                            |         Parent:     
   Points:                            |   Actualpoints:     
--------------------------------------+-------------------------------------

Comment(by backflash):

 rules.js Line 257:
    for (i = 0; i < rs.length; ++i) {

 Conflict with with sub loop
  for(i = 0; i < this.exclusions.length; ++i) {

 Change to use "var" to avoid rest of global variable I back to 0. There is
 the source of your loop. Tested working fix by

 Changing:
 for(i = 0; i < this.exclusions.length; ++i) {
 To
 for(var i = 0; i < this.exclusions.length; ++i) {

 Has been tested as working. I advise (and it's good practice) that var is
 added to every "for loop" to avoid this issue the future.

 Lines I changed:
 43
 50
 166
 257
 166
 176
 206
 211
 ……..

 I don't see how to attach patches here. So here is the fixed file:
 http://pastebin.com/nXrFxvU7

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9507#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online