[tor-bugs] #8607 [Stem]: Controller's cache isn't thread safe

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Apr 19 11:58:43 UTC 2013


#8607: Controller's cache isn't thread safe
-----------------------------+----------------------------------------------
 Reporter:  atagar           |          Owner:  atagar      
     Type:  defect           |         Status:  needs_review
 Priority:  normal           |      Milestone:              
Component:  Stem             |        Version:              
 Keywords:  controller easy  |         Parent:              
   Points:                   |   Actualpoints:              
-----------------------------+----------------------------------------------
Changes (by axitkhurana):

  * status:  needs_revision => needs_review


Comment:

 Thanks for reviewing :)

 * Moved all case lowering to cache functions (set/get), this should fix
 the cache lookup problem.
 * Yeah, .get version is cleaner, changed
 * get_exit_policy returns the value in case of cache hit now.

 commit:
 https://github.com/axitkhurana/stem/commit/b4753ac54c40d992212e1428c19770061e5d1397

 I've added another function for single key, similar to get_conf_map and
 get_conf. Is this the best way of handling single, multiple params?

 commit:
 https://github.com/axitkhurana/stem/commit/2346c2464e66edfde147c4844ddd9286d297eb69

 Cheers,
 Akshit

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8607#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list