[tor-bugs] #8701 [Tor]: Stem doesn't recognize error 555 on attach_stream

[Tor Bug Tracker & Wiki]

#8701: Stem doesn't recognize error 555 on attach_stream
-------------------------+--------------------------------------------------
 Reporter:  cypherpunks  |          Owner:  atagar
     Type:  defect       |         Status:  new   
 Priority:  normal       |      Milestone:        
Component:  Tor          |        Version:        
 Keywords:               |         Parent:        
   Points:               |   Actualpoints:        
-------------------------+--------------------------------------------------
Changes (by atagar):

  * component:  Stem => Tor


Comment:

 Thanks! You uncovered not just a Stem issue but one with Tor. According to
 the spec [https://gitweb.torproject.org/torspec.git/blob/HEAD:/control-
 spec.txt#l839 ATTACHSTREAM should only respond with 250, 552, or 551].

 > I think an InvalidArguments exception would be best suited for this
 error code.

 I'm not entirely clear what a 555 response means. I'd rather not have
 attach_stream() raise a new kind of exception before the spec is updated,
 so raising a OperationFailed for the time being
 ([https://gitweb.torproject.org/stem.git/commitdiff/5268d28c885509de174e5b7c1a657bc0278fd797
 stem change]).

 Would you mind printing raw_content() for this ControlMessage? I'd love to
 include it in our unit tests. :)

 Reassigning this to the tor component for the spec fix.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8701#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online