[tor-bugs] #8596 [Tor]: Inconsistent addrmap events when resolving hostname (regression)

[Tor Bug Tracker & Wiki]

#8596: Inconsistent addrmap events when resolving hostname (regression)
-----------------------+----------------------------------------------------
    Reporter:  Desoxy  |       Owner:                           
        Type:  defect  |      Status:  needs_review             
    Priority:  normal  |   Milestone:  Tor: 0.2.4.x-final       
   Component:  Tor     |     Version:  Tor: 0.2.4.11-alpha      
  Resolution:          |    Keywords:  tor-client controller dns
      Parent:          |      Points:                           
Actualpoints:          |  
-----------------------+----------------------------------------------------

Comment(by atagar):

 > I got confused by the quotes that were already around it, but those are
 part of the ABNF notation, not of the actual protocol. (I'm not very good
 with ABNF.) I commited a fix at [1].

 Thanks! Looks good to me. :)

 > It's a bit complicated: If the DNS resolution worked and an addrmap
 event is generated without a cached flag, then it was added to the cache.
 If resolution failed (e.g. because the domain doesn't exist) and there is
 no cached flag, then it was not be cached (this only happens when using
 the RESOLVE command).

 Hmm, sounds like I should stick with True / False / None then. Thanks for
 the clarification.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8596#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online