[tor-bugs] #7912 [Tor]: Cells that don't get inserted into cell queues can clog connection flushing

[Tor Bug Tracker & Wiki]

#7912: Cells that don't get inserted into cell queues can clog connection flushing
------------------------------------+---------------------------------------
 Reporter:  asn                     |          Owner:                    
     Type:  defect                  |         Status:  needs_review      
 Priority:  major                   |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                     |        Version:                    
 Keywords:  tor-relay 023-backport  |         Parent:                    
   Points:                          |   Actualpoints:                    
------------------------------------+---------------------------------------

Comment(by andrea):

 In 17d64c8ce75c564a3e12cda29c79b9dbf280af67, you have
 circuit_set_p_circid_chan() clearing circ->p_delete_pending and marking
 the circuit ID unusable on the old channel, but
 circuit_set_n_circid_chan() *sets* circ->n_delete_pending in the analogous
 case (which is a no-op since the test for the if already implies that).
 That seems unlikely to be correct.

 Also, if you've marked the circuit ID unusable in the old channel, what's
 going to mark it usable again when the delete is finished?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7912#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online