[tor-bugs] #8642 [TorBrowserButton]: New Identity hangs on control port activity

[Tor Bug Tracker & Wiki]

#8642: New Identity hangs on control port activity
----------------------------------------+-----------------------------------
 Reporter:  mikeperry                   |          Owner:  mikeperry
     Type:  defect                      |         Status:  new      
 Priority:  major                       |      Milestone:           
Component:  TorBrowserButton            |        Version:           
 Keywords:  tbb-crash, MikePerry201304  |         Parent:           
   Points:                              |   Actualpoints:           
----------------------------------------+-----------------------------------
Changes (by mikeperry):

 * cc: mcs, brade (added)


Comment:

 Heh. Found this in nsSocketTransport::OpenOutputStream():
 {{{
         // XXX if the caller wants blocking, then the caller also gets
 buffered!
 }}}

 mcs/brade: This might cause issues with your controller too, if you're
 still using blocking sockets. The only fix I can see is to set the
 segmentCount and segmentSize buffer size arguments of
 nsISocketTransport.openOutputStream to 1..

 I'm also going to add a setTimeout call for good measure, but it doesn't
 look like that will actually do anything (since we timeout on the pipe,
 not the socket)...

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8642#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online