[tor-bugs] #6876 [Tor Relay]: Add config option OutboundBindAddressIPv6

[Tor Bug Tracker & Wiki]

#6876: Add config option OutboundBindAddressIPv6
-------------------------+--------------------------------------------------
 Reporter:  ln5          |          Owner:                    
     Type:  enhancement  |         Status:  needs_revision    
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Relay    |        Version:                    
 Keywords:  ipv6         |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Replying to [comment:7 ln5]:
 > Replying to [comment:6 nickm]:
 > > Hmm.  It feels ouchy to go through this whole business every time we
 want to bind an outbound socket.  Can't we just parse the addresses at
 configuration time, verify that they match the right address family then,
 and simplify the code that does the binding?
 >
 > That's the second option in my initial comment:
 >
 >     Either we add OutboundBindAddressIPv6 or we start parsing
 >     OutboundBindAddress when we read configuration and store two
 outbound
 >     addresses, one for each supported address family.
 >
 > If we do that, wouldn't OutboundBindAddress accepting both IPv4 and
 > IPv6 addresses be the better solution? See branch enh6876_2 for an
 > implementation of that.

 Looks mostly okay.  I think the memset() is wrong: there should be a
 tor_addr_make_null() function instead. I'll write one of those.

 The "if (ext_addr)" test in connection_connect() will always be true: it
 should probably use "tor_addr_is_null()" instead?

 > Should we go even further and store struct sockaddr_in*'s and
 > socklen_t's in or_options_t? Or maybe struct sockaddr_storage's and
 > lenghts?

 We could if we want, but no need to do that here.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6876#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online