[tor-bugs] #6465 [Tor Relay]: Build abstraction layer around TLS

[Tor Bug Tracker & Wiki]

#6465: Build abstraction layer around TLS
-----------------------+----------------------------------------------------
 Reporter:  andrea     |          Owner:  andrea            
     Type:  project    |         Status:  new               
 Priority:  major      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Relay  |        Version:  Tor: unspecified  
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by andrea):

 The bug is that with max > 1 channel_flush_from_first_active_circuit()
 only picks a circuit once, and then flushes cells from it in a loop, and
 if the EWMA code causes the priority order to change partway through that
 loop, a different circuit will come to the head of the pqueue and the
 assert will fail.

 This was a previously existing bug, but the old code always called with
 max == 1, so it was not exposed before channels.  This function could use
 a bit of a refactor anyway, I think.  I'm going to do that and fix the
 bug, and since it would create merge conflicts it's best if that gets done
 based on the channel_t code and merged into master at the same time, but
 it's logically an independent task so I'm going to break it out into a
 separate ticket.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6465#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online