[tor-bugs] #3443 [Tor]: Client with low CBT can't establish any circuits

[Tor Bug Tracker & Wiki]

#3443: Client with low CBT can't establish any circuits
---------------------------------------------------+------------------------
 Reporter:  arma                                   |          Owner:                    
     Type:  defect                                 |         Status:  needs_review      
 Priority:  major                                  |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                                    |        Version:                    
 Keywords:  regression tor-client MikePerry201210  |         Parent:                    
   Points:                                         |   Actualpoints:  3                 
---------------------------------------------------+------------------------

Comment(by nickm):

 I think this branch is actually called (typowise) "bug3433."

 quick review, needs more review and testing.  My comments might be off-
 base; I'm doing this quick so that you have _some_ feedback before the
 storm hits me. Sorry for what I miss and get wrong here.
  * Needs a changes file.
  * Comments shouldn't say stuff like "/* Hack for additional edge-cases of
 #3443 */".  Instead, we explain what the edge cases are and what bug is
 handled if you don't handle them, or else our code becomes impossible to
 follow without reading along with the bugtracker.
  * Don't compare timevals with memcmp; it isn't safe.  They can have
 uninitialized RAM that isn't covered by the fields.  You really need to do
 timercmp instead.
  * It seems that if this "relaxed timeout" thing triggers, it's going to
 hit the logs a lot.  Should that be a notice?
  * What's with the "XXX Need to update this..." ?
  *

 For your questions:
 >Aside from being untested, this definitely needs review because I'm not
 sure I am checking the right state variables for "is the circuit really
 opened" and I'm also not sure I set the timestamp in the right place and
 checked the right circuit state properties there.

 I can try to review more for consistency, and Andrea can too, but it would
 help a lot if you can spell out which invariants and properties you want
 to make sure are maintained by this code.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3443#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online