[tor-bugs] #7089 [Tor]: channel_process_cells: cells handled out of order

[Tor Bug Tracker & Wiki]

#7089: channel_process_cells: cells handled out of order
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  major      |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor        |        Version:                    
 Keywords:  tor-relay  |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 From #6465 :

 {{{
 In channel_process_incoming, do we want to process that queue in-order? It
 seems that doing the DEL_CURRENT approach is likely to have weird
 consequences. Perhaps it would be better to extract all the members into a
 separate list (smartlist_add_all(), smartlist_clear()), then process the
 separate list, then free it.
 }}}

 We even talked about this tonight, and thought that you'd fixed the code.
 Instead it turns out that the function got renamed.

 Please review branch "bug7089" in my public repository.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7089#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online