[tor-bugs] #6757 [Tor]: ClientPreferIPv6ORPort not honoured when running with bridges

[Tor Bug Tracker & Wiki]

#6757: ClientPreferIPv6ORPort not honoured when running with bridges
-----------------------------+----------------------------------------------
 Reporter:  ln5              |          Owner:                    
     Type:  defect           |         Status:  needs_revision    
 Priority:  normal           |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor              |        Version:  Tor: 0.2.4.1-alpha
 Keywords:  ipv6 tor-client  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by ln5):

 We _might_ want to backport this part to 0.2.3.x:

 {{{
     node->ipv6_preferred = (tor_addr_family(&bridge->addr) == AF_INET6 &&
                             !tor_addr_is_null(&node->ri->ipv6_addr));
 }}}

 since 0.2.3.x does

 {{{
     ri->ipv6_preferred = tor_addr_family(&bridge->addr) == AF_INET6;
 }}}

 and will thus potentially prefer an address which is not in the
 descriptor of the bridge. I think that this can happen, f.ex. if the
 bridge withdraws its IPv6 address and uploads a new descriptor
 (matched on digest in get_configured_bridge_by_orports_digest()) and
 probably more.

 Regardless, it seems like the safe and sane thing to do.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6757#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online