[tor-bugs] #6666 [Stem]: Stem wrapper method for the EXTENDCIRCUIT control command

[Tor Bug Tracker & Wiki]

#6666: Stem wrapper method for the EXTENDCIRCUIT control command
----------------------------+-----------------------------------------------
    Reporter:  neena        |       Owner:  neena     
        Type:  task         |      Status:  closed    
    Priority:  normal       |   Milestone:            
   Component:  Stem         |     Version:            
  Resolution:  implemented  |    Keywords:  controller
      Parent:               |      Points:            
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by atagar):

  * status:  needs_review => closed
  * resolution:  => implemented


Comment:

 Thanks! Pushed...

 https://gitweb.torproject.org/stem.git/commitdiff/6f2c1c33931b6fda738468d03ee0f835f0caca6b

 > 1) I would use "path" over "ServerSpec" in the exception message(s),
 since users of stem will be concerned about the names of parameters to
 extend_circuit, not the params to EXTENDCIRCUIT.

 Good point. Changed.

 > 2) Is the "when the circuit id is non-zero" exception needed? The daemon
 should already return "512 No router names provided"...

 Ok, you've convinced me. Doing it let us provide a better message and
 avoid a request to tor we know will fail, but those are pretty weak
 reasons.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6666#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online