[tor-bugs] #7422 [Tor]: tor_cert_decode() memory leak

[Tor Bug Tracker & Wiki]

#7422: tor_cert_decode() memory leak
--------------------+-------------------------------------------------------
 Reporter:  arma    |          Owner:  andrea            
     Type:  defect  |         Status:  needs_review      
 Priority:  normal  |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor     |        Version:                    
 Keywords:          |         Parent:                    
   Points:          |   Actualpoints:                    
--------------------+-------------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 Are you seeing any LOG_PROTOCOL_WARNS from
 channel_tls_process_certs_cell() in channeltls.c? Because it looks like in
 the ERR() macro in that function, "return" should be "goto err;".

 This appears to be a new bug in 0.2.4, based on looking at the code.
 Branch "bug7422" in my public repository will fix at least one plausible
 cause of this.  If there are more cases, I can't see them right now.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7422#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online