[tor-bugs] #7260 [Tor]: MinGW64 & -Werror -Werror

[Tor Bug Tracker & Wiki]

#7260: MinGW64 & -Werror -Werror
--------------------+-------------------------------------------------------
 Reporter:  yayooo  |          Owner:                    
     Type:  defect  |         Status:  needs_review      
 Priority:  normal  |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor     |        Version:  Tor: 0.2.3.24-rc  
 Keywords:          |         Parent:                    
   Points:          |   Actualpoints:                    
--------------------+-------------------------------------------------------

Comment(by nickm):

 Okay; I've split these up, forward-ported to 0.2.4, and taken a different
 approach to the unit test compilation issues. (The failing cases should
 have been using test_eq_ptr, rather than test_eq).

 Please review branch "win64-7260" in my public repository (the top five
 commits at
 https://gitweb.torproject.org/nickm/tor.git/shortlog/refs/heads/win64-7260
 currently).

 I don't see the advantage to "CFLAGS='-Wextra -Werror'" over "./configure
 --enable-gcc-warnings" -- it gives you fewer warnings, *and* forces us not
 to use standard autoconf macros.

 The "char s1[10000000]" fix feels wrong; the point of the first test case
 is to make sure that tor_sscanf rejects scanf widths over 9999.  I wonder
 if you can get around those warnings by changing the argument of
 tor_sscanf from s1 to s_ptr, where s_ptr is declared as "char *s_ptr =
 s1;"

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7260#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online