[tor-bugs] #7272 [Flashproxy]: flashproxy-client socket.error exception on Windows

[Tor Bug Tracker & Wiki]

#7272: flashproxy-client socket.error exception on Windows
------------------------+---------------------------------------------------
 Reporter:  aallai      |          Owner:  dcf         
     Type:  defect      |         Status:  needs_review
 Priority:  minor       |      Milestone:              
Component:  Flashproxy  |        Version:              
 Keywords:              |         Parent:              
   Points:              |   Actualpoints:              
------------------------+---------------------------------------------------
Changes (by aallai):

  * status:  new => needs_review


Comment:

 I have a fix for this at https://github.com/aallai/flashproxy.git, branch
 ticket#7272.

 What I did was remove the setblocking call in listen_socket, so all the
 sockets block.
 The client uses select so it should never block on reads. It can block on
 sends, but the
 *Socket classes use sendall, so it seems like the intention was to block
 there.

 Alternatively the *Socket classes could buffer the data and try resending
 at another time,
 this would probably involve some extra threads though. Let me know if this
 approach
 is better.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7272#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online