[tor-bugs] #5957 [Tor Client]: Our GetFileSize usage doesn't detect errors or handle 64-bit files

[Tor Bug Tracker & Wiki]

#5957: Our GetFileSize usage doesn't detect errors or handle 64-bit files
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 Current version of my fix in branch "getfilesize_64".

 A pseudonymous contributor has suggested that instead of getting 64-bit
 values here, we just unconditionally fail if the result is over 4GB, since
 we would probably never want to map a file that large anyway.

 Needs review.  Also needs testing.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5957#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online