[tor-bugs] #5519 [Vidalia]: Some improvements for torcontrol code (ControlConnection, ControlSocket classes)

[Tor Bug Tracker & Wiki]

#5519: Some improvements for torcontrol code (ControlConnection, ControlSocket
classes)
---------------------+------------------------------------------------------
 Reporter:  sebb     |          Owner:  sebb                
     Type:  task     |         Status:  assigned            
 Priority:  minor    |      Milestone:                      
Component:  Vidalia  |        Version:  Vidalia: 0.3.1-alpha
 Keywords:           |         Parent:                      
   Points:           |   Actualpoints:                      
---------------------+------------------------------------------------------

Comment(by chiiph):

 Nice catch! Would this small patch fix the whole issue?

 {{{
 @@ -241,6 +241,8 @@ ControlConnection::setStatus(Status status)
                                         .arg(statusString(_status))
                                         .arg(statusString(status));
    _status = status;
 +  if (_status == Disconnected)
 +    disconnect();
  }
 }}}

 I think so, but may be there is a better way of handling this. May be just
 calling _controlConn->disconnect() regardless of its connection status,
 and inside it decide to call or not the various disconnect methods *if*
 connected.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5519#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online