[tor-bugs] #5909 [Tor Client]: wcstombs() doesn't guarantee NUL-termination (format_win32_error())

[Tor Bug Tracker & Wiki]

#5909: wcstombs() doesn't guarantee NUL-termination (format_win32_error())
------------------------+---------------------------------------------------
 Reporter:  asn         |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 [censored] points out that `wcstombs()` does not guarantee NUL-termination
 of the output buffer.

 He thinks that with a sufficiently large error message in
 `format_win32_error()`, and if `UNICODE` is set, `tor_strdup()` will also
 copy chunks of the stack.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5909>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online