[tor-bugs] #5857 [TorBrowserButton]: Redesign JS Hook injection

[Tor Bug Tracker & Wiki]

#5857: Redesign JS Hook injection
------------------------------+---------------------------------------------
 Reporter:  mikeperry         |          Owner:  mikeperry
     Type:  enhancement       |         Status:  new      
 Priority:  major             |      Milestone:           
Component:  TorBrowserButton  |        Version:           
 Keywords:                    |         Parent:           
   Points:                    |   Actualpoints:           
------------------------------+---------------------------------------------
 Georg Koppen found a race condition in our Javascript hook application
 that allows the hooks to be bypassed. Right now, they only exist to
 project window.screen and associated resolution information, so we can
 probably just replace them with a patch (#5856).

 However, the technique is useful, and we might want to use it in the
 future as opposed to Firefox patches to tweak other APIs (#5293, #5666)...
 This ticket is to see if we can create a more reliable way of injecting js
 hooks that is more directly supported by the browser.

 Or, maybe we just want to patch Firefox for everything. The patch approach
 will help ensure stuff stays on Mozilla's radar.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5857>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online