[tor-bugs] #5458 [Tor Client]: Clients should warn in the event of excessive circuit failures

[Tor Bug Tracker & Wiki]

#5458: Clients should warn in the event of excessive circuit failures
-----------------------------+----------------------------------------------
 Reporter:  mikeperry        |          Owner:  mikeperry         
     Type:  defect           |         Status:  needs_review      
 Priority:  major            |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client       |        Version:                    
 Keywords:  MikePerry201205  |         Parent:  #5456             
   Points:  6                |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by nickm):

 Replying to [comment:12 mikeperry]:
 > nickm: All of the above sounds fine. I'll try to get through all of them
 in the next revision. I assume you'll just want a fresh branch with a
 single commit?

 Either way is fine.  For bigger stuff, I'd prefer multiple commits,
 possibly to be squashed, but this is a small enough patch I think I can
 read the new version well either way.

 > Also, I'm still wondering how to handle removing guards and bridges (or
 perhaps just marking them as down/invalid/bad?) in the event they hit the
 'warn' limit. The most surefire way seems to be to remove them from both
 bridge and guard lists, as well as remove them from the config (if
 present), but this seems like it might be rude. Perhaps marking them to be
 avoided somehow is better? Any suggestions?

 Removing them has the problem that they can just get added in.  Bridges,
 for example, will get inserted again the next time we load the
 configuration.  I think the right answer is marking them as to be avoided.
 This could be done as a new flag, or by having the code that looks at the
 nodes' status to find good / sufficent entries also check to see if the
 ratio of failed->attempted circuits is too high.

 > Also, as a general process matter for future revisions, do you also
 prefer needs_review tickets to be assigned to you to notice, or is it
 enough for you to be in the Cc?

 I don't need either; I look at all the needs_review tickets assigned to a
 Tor component fairly regularly.  The important fields for me are the
 status, the component, and the milestone.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5458#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online