[tor-bugs] #5528 [Tor Client]: router->address is redundant with router->addr

Fri Mar 30 03:24:06 UTC 2012

#5528: router->address is redundant with router->addr
-------------------------+--------------------------------------------------
 Reporter:  arma         |          Owner:                    
     Type:  enhancement  |         Status:  new               
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by arma):

 Replying to [comment:4 rransom]:
 > How will this affect Tor's ability to fetch directory information from
 the DirPort of a relay like dannenberg which has a ‘real web server’ in
 front of Tor?

 Should be unrelated. Basically right now we preemptively malloc a string
 version of router->addr, and then carry it around ever after for when we
 need it. We could instead generate it on demand and then not keep it in
 between uses. Should have no impact on external-visible behavior.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5528#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online