[tor-bugs] #5472 [Stem]: Stem version parser matches git hash too

[Tor Bug Tracker & Wiki]

#5472: Stem version parser matches git hash too
--------------------+-------------------------------------------------------
 Reporter:  neena   |          Owner:  neena         
     Type:  defect  |         Status:  needs_revision
 Priority:  normal  |      Milestone:                
Component:  Stem    |        Version:                
 Keywords:          |         Parent:                
   Points:          |   Actualpoints:                
--------------------+-------------------------------------------------------
Changes (by atagar):

  * status:  needs_review => needs_revision


Comment:

 > Sorry, put it off for later and forgot. Won't happen again.

 No worries, I make pydoc mistakes constantly. :)

 > We won't be able to reuse the function for different outputs if we do
 this.

 True, though we don't need alternative outputs yet and if we did it will
 be easy to refactor. I would also argue that if/when we want multiple
 system_tor_version tests we should add a generator function to avoid
 copying the "This is experimental software." boilerplate, but that too
 isn't needed until we have more things to test.

 The plain mock function is simpler, and keeping code simple is a very good
 thing. You're right that if we add several more tests later then your
 lambda function will be preferable. But lets not optimize for that until
 it happens.

 > Well, I'm feeling really good about my code now. :)

 Great, glad that you generally like the changes. :)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5472#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online