[tor-bugs] #5380 [Tor Client]: clients that never restart never drop old guards

[Tor Bug Tracker & Wiki]

#5380: clients that never restart never drop old guards
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  new               
 Priority:  major       |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
 When we get a consensus we check whether to drop guards that have been
 down long enough.

 But we only compare chosen_on_date to now when we're loading the state
 file, which we only do at start.

 So if the Tor client stays running for more than a month or two, its guard
 behavior deviates from normal.

 Discovered while talking to Tariq about his guard simulation attack graphs
 and trying to puzzle through his unintuitive results.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5380>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online