[tor-bugs] #5324 [Tor Relay]: connection_handle_read_impl() has wrong function comment?

[Tor Bug Tracker & Wiki]

#5324: connection_handle_read_impl() has wrong function comment?
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 connection_handle_read_impl() says
 {{{
  * This function gets called from conn_read() in main.c, either
  * when poll() has declared that conn wants to read, or (for OR conns)
  * when there are pending TLS bytes.
 }}}

 First of all, there is no conn_read() anymore. But also, I suspect this
 function is no longer called when there are pending TLS bytes?

 I worry that libevent only calls the callback when the socket has
 something to read, and not when the ssl object has pending bytes. That
 would mean we are forced to keep our "read the whole ssl record even if it
 means our read bucket goes negative" feature? See #5323.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5324>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online