[tor-bugs] #3589 [Tor Bridge]: Advertise bridge pluggable transports using extra-info lines

[Tor Bug Tracker & Wiki]

#3589: Advertise bridge pluggable transports using extra-info lines
-------------------------+--------------------------------------------------
 Reporter:  asn          |          Owner:                    
     Type:  enhancement  |         Status:  needs_revision    
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Bridge   |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Reviewing...

 I don't like including transports.h in circuitbuild.h.  Presumably that's
 just for the transport_t declaration.  If so the right fix is to do a
 forward-declaration of struct transport_t in circuitbuild.h, and have the
 functions take that instead.

 Looks like there's now a bogus newline before proxy_prepare_for_restart.

 In the future, please don't re-order functions within a file except in a
 commit that does nothing but re-order functions.  No need to change this
 time though.

 I'd be more comfortable if pt_configure_remaining_proxies would only call
 mark_my_descriptor_dirty when there were previously unconfigured proxies.

 The documentation for the addr field in transport_t doesn't give me enough
 information to say whether t->addr is right thing to stick in a transport
 line.

 Is this tested?

 No changes file.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3589#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online