[tor-bugs] #6031 [Tor Hidden Services]: Distinguish when a Tor HS is "not found" vs "not reachable" (exists / does not exists)

[Tor Bug Tracker & Wiki]

#6031: Distinguish when a Tor HS is "not found" vs "not reachable" (exists / does
not exists)
---------------------------------+------------------------------------------
 Reporter:  naif                 |          Owner:                    
     Type:  enhancement          |         Status:  needs_revision    
 Priority:  normal               |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------
Changes (by andrea):

  * status:  needs_review => needs_revision


Comment:

 I've tested this and it seems to work as advertised.  Two issues, though:

 First, RFC 1928 does not define status codes 0x23 or 0x24, and describes
 all status codes >= 0x09 as simply 'unassigned'.  It requires that clients
 treat any status other than 0x00 as an error and disconnect, so the scope
 for pathological behavior *from conforming clients* is limited here, but
 do we know how well clients behave in practice?

 This may at least lead to some rather non-transparent error messages for
 the user.  In testing, status code 0x23 causes privoxy to report "Privoxy
 was unable to socks5-forward your request http://uhd2bclqqu2sfch6.onion/
 through 127.0.0.1: SOCKS5 negotiation protocol error", for example.

 Without this patch it produces "Privoxy was unable to socks5-forward your
 request http://uhd2bclqqu2sfch6.onion/ through 127.0.0.1: SOCKS5 host
 unreachable", which seems to me to have a more recognizable relation to
 the actual error condition.

 The tor log messages are perfectly clear in this case, though.

 Second, this fails make check-spaces: src/or/or.h line 627 and
 src/or/reasons.c line 76 are wider than 80 characters, and
 src/or/reasons.c line 140 is a second consecutive blank line.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6031#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online