[tor-bugs] #4567 [Tor Bridge]: Extend Tor's UPnP support for pluggable transport ports

[Tor Bug Tracker & Wiki]

#4567: Extend Tor's UPnP support for pluggable transport ports
------------------------+---------------------------------------------------
 Reporter:  karsten     |          Owner:  asn                     
     Type:  project     |         Status:  needs_revision          
 Priority:  normal      |      Milestone:  Sponsor G: June 30, 2012
Component:  Tor Bridge  |        Version:                          
 Keywords:              |         Parent:                          
   Points:              |   Actualpoints:                          
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 okay, so fwict all the commits before eff60fc5fc are refactoring, code
 moving, etc that don't actually have much to do with this ticket.  Worth
 merging anyway, though, of course : I'll be especially glad to say goodbye
 to the old behavior of mp->transports (where sometimes it contains strings
 and sometimes it contains transports).

 Making ports generic in eff60fc5fc is also a win IMO: "There are only
 three numbers in computer science: zero, one, and infinity."  I think the
 tor_parse_long calls in that commit are wrong, though: they have a maximum
 of 6556, when the maximum port number is 65535.

 d180c576da516f is the big Tor change.  BTW, there is no such thing as
 "Refactor Tor to support the new tor-fw-helper protocol."  Refactoring
 means to improve the code without changing its functionality or behavior.
 I try not to get pedantic about stuff like that, but when I see a commit
 which claims to be refactoring but isn't, I get all twitchy.

 The right way to stick things together for a log message is esc_for_log
 and its kin.

 The documentation for any function taking a smartlist_t really needs to
 explain what the smartlist contains.

 In the loop that builds argv, I'd like more assurance that argv_index can
 never overflow.

 The manpage doc/tor-fw-helper.1.txt needs to change.

 When I tried to build this, I got an error because
 get_list_of_ports_to_forward doesn't have a prototype in config.h.  Have
 you been building this with --enable-gcc-warnings?  Please do, if not.

 Needs a changes file.

 Breaks make check-spaces.

 How much have you been able to test this?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4567#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online