[tor-bugs] #6167 [Tor Hidden Services]: Possible assertion failure in connection_ap_handshake_attach_circuit()

[Tor Bug Tracker & Wiki]

#6167: Possible assertion failure in connection_ap_handshake_attach_circuit()
---------------------------------+------------------------------------------
 Reporter:  nickm                |          Owner:                    
     Type:  defect               |         Status:  new               
 Priority:  major                |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Hidden Services  |        Version:                    
 Keywords:                       |         Parent:                    
   Points:                       |   Actualpoints:                    
---------------------------------+------------------------------------------
 Vektor reports that an AdvOR user reported a failure of the assertion
 {{{
 tor_assert(introcirc->_base.purpose ==  CIRCUIT_PURPOSE_C_INTRODUCING);
 }}}
 in connection_ap_handshake_attach_circuit().

 His fix is to replace the test in circuit_is_acceptable() so that
 CIRCUIT_PURPOSE_C_INTRODUCE_ACK_WAIT circuits can no longer get returned.

 We should investigate.  Filing for 0.2.2 since ISTR that's what AdvOR is
 tracking.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6167>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online