[tor-bugs] #6468 [Tor Relay]: OR connection early-flush code in connection_handle_write_impl is needless

[Tor Bug Tracker & Wiki]

#6468: OR connection early-flush code in connection_handle_write_impl is needless
-----------------------+----------------------------------------------------
 Reporter:  nickm      |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by arma):

 Now it has
 {{{
     ssize_t extra = 0;
 ...
     if (extra) {
       conn->outbuf_flushlen += extra;
       connection_start_writing(conn);
     }
 }}}
 ?

 Also, it needs to change the comment header that says
 {{{
  * If it's an OR conn and an entire TLS record is ready, then try to
  * flush the record now. Similarly,
 }}}

 Other than those, it sounds like a plausible plan to me. Since
 OR_CONN_HIGHWATER is 32KB, this will change behavior in practice?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6468#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online