[tor-bugs] #6472 [Tor Relay]: Assertion !connection_is_on_closeable_list

[Tor Bug Tracker & Wiki]

#6472: Assertion !connection_is_on_closeable_list
-----------------------+----------------------------------------------------
 Reporter:  torland    |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  major      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:  Tor: 0.2.3.19-rc  
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------

Comment(by nickm):

 Reported in IRC: it could conceivably be from dns_found_answer() or
 connection_exit_connect.

 If so (or even if not), I suggest two fixes and a workaround:
   * Every place that calls connection_free except for connection_unlink(),
 we need to audit to make it's not reachable on on an already-marked-for-
 close connection.
   * We should start with the two places above.
   * We should change the behavior of connection_free() for a connection on
 the closeable list to log a bug and return, rather than freeing the
 connection.  Since it's on the closeable list, it should get freed soon
 anyway.)

 The reporter suggests that we should call connection_dns_remove earlier
 (perhaps when we mark connections?), and that it should work differently.
 more info to follow

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6472#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online