[tor-bugs] #6445 [Tor Relay]: Version spec revisions

Tor Bug Tracker & Wiki torproject-admin at torproject.org
Mon Jul 23 15:35:46 UTC 2012


#6445: Version spec revisions
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:              
     Type:  enhancement  |         Status:  needs_review
 Priority:  minor        |      Milestone:              
Component:  Tor Relay    |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------

Comment(by nickm):

 I'm not sure I get it.  When I look at the code, it seems to do a proper
 (that is, forward) lexical comparison.  Here's a snippet I added to
 test_dir_versions to verify this:
 {{{
   test_eq(1, tor_version_as_new_as("Tor 0.2.1.1-rc",
                                    "Tor 0.2.1.1-alpha)"));
   test_eq(0, tor_version_as_new_as("Tor 0.2.1.1-rc",
                                    "Tor 0.2.1.1-zeta)"));
 }}}

 It seems to pass.  What makes you think that the comparison is happening
 reverse-lexically?

 (BTW, lexically DOES NOT mean alphabetically.  Alphabetical comparison is
 approximately what strcasecmp does. Lexical comparison is what strcmp
 does.)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6445#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list