[tor-bugs] #6341 [Tor Relay]: connection_or_flush_from_first_active_circuit() does wrong thing when ewma_enabled

[Tor Bug Tracker & Wiki]

#6341: connection_or_flush_from_first_active_circuit() does wrong thing when
ewma_enabled
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  needs_review      
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 Man, that's some messy code.

 I'm in favor of making the above change in 0.2.3, and doing some radical
 refactoring in 0.2.4.

 Possible radical refactoring: Having the non-ewma case around seems more
 or less pointless, and ugly.  We should get rid of it if we can, and
 refactor stuff until the whole ewma logic can have unit tests.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6341#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online