[tor-bugs] #6341 [Tor Relay]: "if (circ != conn->active_circuits)" in connection_or_flush_from_first_active_circuit() is wrong?
Tor Bug Tracker & Wiki
torproject-admin at torproject.org
Sat Jul 7 17:14:12 UTC 2012
#6341: "if (circ != conn->active_circuits)" in
connection_or_flush_from_first_active_circuit() is wrong?
-----------------------+----------------------------------------------------
Reporter: arma | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: Tor Relay | Version:
Keywords: | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Here are our cryptic hints:
{{{
connection_or_flush_from_first_active_circuit(): "if (circ !=
conn->active_circuits)" is wrong, especialy with ewma. read comments, that
means it show how stuff is broken.
that means random crashes for "connection_write_to_buf(NULL->body" if ewma
enabled.
just remove that condition block, no need any goto before every stream
started reads and all circs with empty queue marked as inactive.
"&& queue->head" saves from crashes, but that condition is wrong anyway.
you can't unblock streams when you need it.
why need "re-add the cell_ewma_t" inside for{} ? what purpose for{} if you
never can flush more than 1 cell for ewma anyway? Why there are no
consistent logic for just one small func?
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6341>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list