[tor-bugs] #4942 [Tor Relay]: HeartbeatPeriod has a fencepost error

[Tor Bug Tracker & Wiki]

#4942: HeartbeatPeriod has a fencepost error
-----------------------+----------------------------------------------------
 Reporter:  arma       |          Owner:                    
     Type:  defect     |         Status:  new               
 Priority:  normal     |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay  |        Version:                    
 Keywords:             |         Parent:                    
   Points:             |   Actualpoints:                    
-----------------------+----------------------------------------------------
 Scott Bennett points out on tor-relays that the heartbeat messages are a
 second later than expected each time.

 Sebastian confirms:
 {{{
 Jan 22 00:30:50.000 [notice] Heartbeat: Tor's uptime is 11 days 6:00
 hours, with 384 circuits open. I've sent 183.45 GB and received 26.61 GB.
 Jan 22 06:30:51.000 [notice] Heartbeat: Tor's uptime is 11 days 12:00
 hours, with 358 circuits open. I've sent 185.58 GB and received 27.16 GB.
 Jan 22 12:30:52.000 [notice] Heartbeat: Tor's uptime is 11 days 18:00
 hours, with 1124 circuits open. I've sent 188.79 GB and received 27.77 GB.
 }}}

 Sebastian suggests
 {{{
 -      time_to_next_heartbeat < now) {
 +      time_to_next_heartbeat <= now) {
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4942>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online