#4893: Rename inconsistent function and type names
------------------------+---------------------------------------------------
Reporter: nickm | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by Sebastian):
Do we have this convention documented anywhere? I was never too bothered
with the 'env' stuff. It seemed to set up the crypto environment, so I
treated it as being descriptive of what it does.
That said, the script doesn't introduce breakage of anything per se, and
if you feel these are an improvement I also don't object to the new names.
(To illustrate what I meant with the first sentence, with the rename
script this:
{{{
/* environment setup */
crypto_pk_env_t *crypto_new_pk_env(void);
void crypto_free_pk_env(crypto_pk_env_t *env);
}}}
becomes this:
{{{
/* environment setup */
crypto_pk_t *crypto_pk_new(void);
void crypto_pk_free(crypto_pk_t *env);
}}}
)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4893#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online