[tor-bugs] #1297 [Tor Hidden Services]: Update hidden service logic to be more resilient to timeout

[Tor Bug Tracker & Wiki]

#1297: Update hidden service logic to be more resilient to timeout
------------------------------------+---------------------------------------
    Reporter:  mikeperry            |       Owner:  rransom           
        Type:  defect               |      Status:  needs_review      
    Priority:  major                |   Milestone:  Tor: 0.2.3.x-final
   Component:  Tor Hidden Services  |     Version:  0.2.2.10-alpha    
  Resolution:  None                 |    Keywords:                    
      Parent:  #2552                |      Points:                    
Actualpoints:                       |  
------------------------------------+---------------------------------------

Comment(by nickm):

 Looks good, I think.  Could I have some comments explaining what can
 happen to a circuit once hs_circ_has_timed_out is set on it?  The current
 comments do a good job of explaining when the flag is set, but not the
 allowable transitions out of that state.  (So, the idea is that a "timed
 out" circuit is not really timed out, but allowed to stick around a little
 longer in case it works, in which case we declare it to be okay?)

 Why would you want to set CloseHSClientCircuitsImmediatelyOnTimeout ? Is
 it just there for testing, or what?

 Is there any limit on how many times this code can relaunch circuits on
 timeout for the same request?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1297#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online