[tor-bugs] #4528 [Tor Relay]: read_to_buf_tls(): Inconsistency in code

[Tor Bug Tracker & Wiki]

#4528: read_to_buf_tls(): Inconsistency in code
--------------------------+-------------------------------------------------
    Reporter:  troll_un   |       Owner:                    
        Type:  defect     |      Status:  needs_review      
    Priority:  normal     |   Milestone:  Tor: 0.2.3.x-final
   Component:  Tor Relay  |     Version:                    
  Resolution:             |    Keywords:  easy              
      Parent:             |      Points:                    
Actualpoints:             |  
--------------------------+-------------------------------------------------
Changes (by hellais):

  * status:  new => needs_review


Comment:

 If I understand correctly what you mean in this bug you are saying that
 while we check for check_no_tls_errors() inside of flush_buf_tls() we
 don't do the same in read_to_buf_tls().

 I looked at it and you appear to be correct. This is fixed inside of my
 master branch: https://gitweb.torproject.org/user/art/tor.git.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4528#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online