[tor-bugs] #5141 [Obfsproxy]: obfsproxy Segmentation fault on incomplete command line

[Tor Bug Tracker & Wiki]

#5141: obfsproxy Segmentation fault on incomplete command line
-----------------------+----------------------------------------------------
 Reporter:  murble     |          Owner:  asn           
     Type:  defect     |         Status:  needs_revision
 Priority:  normal     |      Milestone:                
Component:  Obfsproxy  |        Version:                
 Keywords:             |         Parent:                
   Points:             |   Actualpoints:                
-----------------------+----------------------------------------------------
Changes (by asn):

  * status:  needs_review => needs_revision


Comment:

 Hm, this patch looks like a work around of the actual bug in
 `protocols/obfs2.c:parse_and_set_options()`.

 We should probably keep Nick's patch, but also fix the bad CLI parsing
 code in `protocols/obfs2.c`. I think the problem there is that we trust
 `n_options` too much, which does not work well when we have optional
 arguments.

 Unfortunately, I don't have a computer at the moment to prepare a fix.
 I'll do ASAP, if no one else does it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5141#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online