[tor-bugs] #5151 [Tor Bridge]: Bridge ignores NoAdvertise option in ORPort configurations

[Tor Bug Tracker & Wiki]

#5151: Bridge ignores NoAdvertise option in ORPort configurations
------------------------+---------------------------------------------------
 Reporter:  karsten     |          Owner:  ln5
     Type:  defect      |         Status:  new
 Priority:  normal      |      Milestone:     
Component:  Tor Bridge  |        Version:     
 Keywords:              |         Parent:     
   Points:              |   Actualpoints:     
------------------------+---------------------------------------------------
 murble found that bridges ignore the NoAdvertise option in ORPort
 configurations.  These are the ORPort configurations of murble's bridges:

 {{{
 ORPort "0.0.0.0:9001"
 ORPort "[::]:9001 NoAdvertise IPv6Only"
 }}}

 {{{
 ORPort "[::]:9090 IPv6Only NoAdvertise"
 ORPort "0.0.0.0:9090 NoAdvertise"
 ORPort 0.0.0.0:443 NoListen
 }}}

 The first problem is that Tor ignores the NoAdvertise option because of
 this copy-paste error in `config.c`:

 {{{
 5769       cfg->no_listen = no_listen;
 5770       cfg->no_listen = no_advertise;
 }}}

 The second problem is that Tor writes this log message on ''notice''
 level:

 {{{
 My line is <or-address [::]:9090
 >
 }}}

 This log message was probably meant to debug things and should go away.

 So, after fixing the first problem, the bridge still wrote the "My line is
 ..." log message, but didn't include an "or-address" line in its
 descriptor.  Which is somewhat strange, because the code looks like the
 "My line is ..." line is only written when the bridge includes the "or-
 address" line afterwards.  More debugging necessary, but maybe this is a
 start.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5151>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online